[scope] allow taking address of local in @safe code

[WalterBright]

With the scope improvements, this restriction is no longer necessary. It'll be tracked analogously to the way static arrays are tracked when a slice is taken.

[mihails-strasuns]

I have tweaked title a bit to avoid possible confusion that this may target master.

Can you please add a test case?

[MartinNowak]

There are still the @safe failures in phobos that need to get fixed (in dmd!!!).

[mathias-lang-sociomantic]

Also the issue reported here: https://forum.dlang.org/post/mrncdymkdumyqfzlysig@forum.dlang.org

[WalterBright]

There are still the @safe failures in phobos that need to get fixed (in dmd!!!).

It all works on my system. I think the problem is one endemic to having a feature branch - it has diverged.

[MartinNowak]

It all works on my system. I think the problem is one endemic to having a feature branch - it has diverged.

That's a premature conclusion, the @safe failures where already in the original return scope PR. Maybe it's indeed a problem with the CI setup for feature branches, will check later today, but I guess it actually has to do with the changes.

Regarding diversion, our setup also supports identically named feature branches in druntime/phobos, that can be used to avoid phobos from getting out of sync, or for features that need compiler and library changes.
Alternatively once can merge dmd@master into dmd@scope to get the latest dmd state.

I wouldn't know which safety related changes would cause such phobos error, unless sth. got merged into dmd@master that actually belonged into dmd@scope.
https://travis-ci.org/dlang/dmd/jobs/178268068#L1076

[MartinNowak]

Please add some test cases for taking the address in @safe code.

[WalterBright]

Also added test case for taking address of local.

[MartinNowak]

The lifetime of pp is shorter than the lifetime of p, so shouldn't this be allowed?
We could go with a conservative implemenation for now.

[WalterBright]

You're right. I'll file an enhancement request.

[WalterBright]

https://issues.dlang.org/show_bug.cgi?id=16795