Skip to content

Update public/private attributes of OutBuffer fields.#6334

Merged
MartinNowak merged 1 commit intodlang:stablefrom
ibuclaw:notprivate
Dec 18, 2016
Merged

Update public/private attributes of OutBuffer fields.#6334
MartinNowak merged 1 commit intodlang:stablefrom
ibuclaw:notprivate

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Dec 18, 2016

This is so that the D and C++ sources match.

@MartinNowak - is stable the right place to go?

This is so that the D and C++ sources match.
@MartinNowak
Copy link
Member

Generally stable is the right place for all fixes, guess this fixes your C++ headers, so somewhat of a yes.

@MartinNowak
Copy link
Member

Auto-merge toggled on

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 18, 2016

guess this fixes your C++ headers

I'm going through all C++ headers in the stable branch and seeing what doesn't compile. I'm hoping that it won't be too painful to just backport them into gdc. Using the same headers for the bootstrap process would make things easier.

So long as the codegen passes can interact with both the last C++ release and current stable without special recognition then I can see it all going to be plain sailing.

@MartinNowak MartinNowak merged commit 3129ab6 into dlang:stable Dec 18, 2016
@wilzbach
Copy link
Contributor

So long as the codegen passes can interact with both the last C++ release and current stable without special recognition then I can see it all going to be plain sailing.

FWIW I am still hoping that the C++ headers will be automatically generated in a somewhat near future. Ideally this should make your life a lot easier, because there can't be an out-of-sync case anymore.

@ibuclaw ibuclaw deleted the notprivate branch December 18, 2016 23:23
@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 18, 2016

Yeah, in the meantime, what I'm doing is a very good test of the current upstream codebase. At least once I've synced it up, there'll be a high incentive to keep it that way.

So you'll be berated within days/a week, rather than several months down the line. ;-)

@WalterBright
Copy link
Member

Note that dmd no longer needs any of those C++ .h files.

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 19, 2016

@WalterBright - My current plan is to align the headers up between gdc and dmd-stable. Once that is done, then toggling between D and C++ implementations should be pretty straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants