fix errors with AVX vector code generation#6394
Merged
andralex merged 1 commit intodlang:masterfrom Jan 3, 2017
Merged
Conversation
andralex
approved these changes
Jan 3, 2017
| if (config.avx && | ||
| ((e1->Eoper == OPind && !e1->Ecount) || e1->Eoper == OPvar && !isregvar(e1,&varregm,&varreg)) || | ||
| tysize(ty) == 32 | ||
| tysize(ty) == 32 && !isregvar(e1,&varregm,&varreg) |
Member
|
Auto-merge toggled on |
Member
|
Forcing SIMD loads to go through the stack is obviously a really bad idea. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was initially mystified how dmd could pass the test suite with these bugs, since the test suite was failing when I tried them. But then I remembered Brad had said that many (most?) of the test machines do not have AVX-capable CPUs, and hence the AVX tests did not run.