[scope] fix Issue 17076 don't infer 'return' if return type doesn't have pointers#6420
Merged
andralex merged 1 commit intodlang:masterfrom Jan 9, 2017
Merged
[scope] fix Issue 17076 don't infer 'return' if return type doesn't have pointers#6420andralex merged 1 commit intodlang:masterfrom
andralex merged 1 commit intodlang:masterfrom
Conversation
Member
Author
|
Blocking dlang/druntime#1733 |
WalterBright
added
the
Review:Blocking Other Work
Member
|
Also fixes https://issues.dlang.org/show_bug.cgi?id=17076, which is the same as the test case. I've just browsed the code cursorily, but shouldn't it avoid inferring |
Member
Author
|
If the int parameter is cast to a pointer, it should infer. That's why the check is on the return type. |
WalterBright
changed the title
Member
|
Kudos to anyone who can explain how I can figure why circleci failed. |
tramker
pushed a commit
to tramker/dmd
that referenced
this pull request
Jun 14, 2017
[scope] fix Issue 17076 don't infer 'return' if return type doesn't have pointers [REG2.073] Fix Issue 17117 - erroneous "escaping reference to local variable" Signed-off-by: Martin Krejcirik <mk@krej.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accomplished by not needing to check escaping pointers via return if the return type doesn't have indirections.