eliminate array bounds error helper function#6536
Merged
andralex merged 1 commit intodlang:masterfrom Feb 16, 2017
Merged
Conversation
| * Construct elem to run when an array bounds check fails. | ||
| * Returns: | ||
| * elem generated | ||
| */ |
Contributor
There was a problem hiding this comment.
No documentation for the parameters.
Contributor
There was a problem hiding this comment.
Can loc be const since it's passed by ref and not modified, as far as I can see.
WalterBright
force-pushed
the
darrayp
branch
from
07fd1c0 to
8dd5535
Compare
WalterBright
force-pushed
the
darrayp
branch
from
8dd5535 to
5f6578a
Compare
andralex
approved these changes
Feb 16, 2017
| if (SegData[seg]) | ||
| { seg_data *pseg = SegData[seg]; | ||
| { | ||
| seg_data *pseg = SegData[seg]; |
Member
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated the code that builds the error call into
buildArrayBoundsError()and then fixed it to load the file pointer directly rather than call a helper function.Once this works, I'll delete the old code, and then amend it to reduce the bloat from redundant file strings being emitted.