Fix issue 17169 - New default ddoc theme merges all paragraphs except…

[jacob-carlborg]

… the first

[dlang-bot]

Fix	Bugzilla	Description
✓	17169	New default ddoc theme merges all paragraphs except the first

[jacob-carlborg]

@Abscissa

[WalterBright]

What does this actually emit given the source code in the bug report?

[jacob-carlborg]

What does this actually emit given the source code in the bug report?

It adds <br><br> between P2 and P3. For the full output see [1], it's by default minimized in the diff view. This is more in line of how it looked like before the new ddoc theme. Here's a before and after example of the rendered result:

Before:

After:

[1] https://github.com/jacob-carlborg/dmd/blob/4d67aee38c9b9d4e2a6037bc73b6fcd9d82d13ea/test/compilable/extra-files/ddoc17169.html

[jacob-carlborg]

The failing Travis CI tests are unrelated, I think it fails for all PRs. See #6539.

[wilzbach]

@jacob-carlborg all regression fixes should target stable ;-)

[jacob-carlborg]

all regression fixes should target stable ;-)

I hate this 😃.

[jacob-carlborg]

@wilzbach Will I cause any problems if I change the target branch to "stable"?

[wilzbach]

@wilzbach Will I cause any problems if I change the target branch to "stable"?

GitHub will try to rebase your commit to stable - in the worst case you need to do it yourself afterwards, but I haven't had any problems yet.

[jacob-carlborg]

This doesn't look correct.

[jacob-carlborg]

Fixed, no targeting "stable".

[jacob-carlborg]

@WalterBright @MartinNowak @andralex ping, this is a pretty trivial PR and a regression fix.

[jacob-carlborg]

@CyberShadow

[MartinNowak]

GitHub will try to rebase your commit to stable - in the worst case you need to do it yourself afterwards, but I haven't had any problems yet.

No, github does not do the rebase, you have to do it yourself after changing the base commit.
git rebase --onto upstream/stable upstream/master should work
It's important to push the rebased commit after changing the base branch in github for the tester to get notified and pick up the new base branch.

[jacob-carlborg]

Thanks.