Fix inconsistency between JSON output and ddoc output#6621
Fix inconsistency between JSON output and ddoc output#6621andralex merged 1 commit intodlang:masterfrom
Conversation
|
This fixes dlang/ddox#86. |
|
Oops, huge change in the resulting documents.... How can I see the diffs? |
|
Somehow ddox associate the document to member of the template, not the template itself. Does anybody know why? |
|
Since this is fixing a bug, can you please file a bugzilla issue for it? That will make the changelog easier and more organized. Thanks! |
|
Thanks for your pull request, @yshui! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla references
|
|
@WalterBright But this change also has big impact on the ddox output. Can you review the change? |
|
We do have tests for the JSON output, simply add to that. We can then separaretly check ddox whether it correctly processes those entities. |
|
cc @yshui there seem to be errors in the autotester, please check so we move this forward? |
JSON should include version blocks in templates, same as ddoc.
|
Seems DAutoTest can't find libdparse? |
|
cc @MartinNowak |
|
Digger says this caused a regression: https://issues.dlang.org/show_bug.cgi?id=20742 It appears the json output is now putting out MORE than what ddoc puts out, including docs inside a |
missed the early return. [1] dlang#6621
PR dlang#6621 took the code for pending `ConditionalDeclaration`s from doc.d but missed the early return.
JSON should include version blocks in templates, same as ddoc.
BTW, I think we should include both branches of static if in ddoc output.