Issue 6578 - Wrong type deduction for NewExp and __ctor with struct#666
Merged
9rnsr merged 1 commit intodlang:masterfrom Mar 6, 2013
Merged
Issue 6578 - Wrong type deduction for NewExp and __ctor with struct#6669rnsr merged 1 commit intodlang:masterfrom
9rnsr merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
building dmd fails. |
Contributor
Author
|
I know. |
Contributor
Author
|
Update. |
Member
|
Merge conflict, please rebase. Thanks! |
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Oct 22, 2012
Make std.math compile on non-x86 by stubbing/asserting things out.
|
I hope we can get this in soon. One of the DConf talks depends on being able to construct immutable struct objects. |
Contributor
|
I think that this is not good patch. I never argue that hackish itself is a problem, but this hack does not move things toward correct direction. |
Contributor
Author
|
I don't see how this is a hack. That said, I do think it's a bad patch, because it tried to change the parameter from an expression to a type, which is unneeded and should not be mixed in with this patch. |
Add the constructor's modifiers to the result type, instead of replacing them.
Contributor
Author
|
Updated. |
Collaborator
|
LGTM. Kenji, do you still think there's a problem with this? |
Contributor
|
OK, LGTM, too. |
9rnsr
added a commit
that referenced
this pull request
Mar 6, 2013
Issue 6578 - Wrong type deduction for NewExp and __ctor with struct
Contributor
Author
|
Thanks guys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For NewExp, the type is incorrectly being set to the constructor's return type.
Same thing for constructor calls.
http://d.puremagic.com/issues/show_bug.cgi?id=6578