Revert #6026 - build compiler w/ optimizations to speed up test suite#6746
Closed
ibuclaw wants to merge 1 commit intodlang:masterfrom
Closed
Revert #6026 - build compiler w/ optimizations to speed up test suite#6746ibuclaw wants to merge 1 commit intodlang:masterfrom
ibuclaw wants to merge 1 commit intodlang:masterfrom
Conversation
Member
|
Leaving optimizations on should be fine, but it should not be |
Member
Author
Indeed, this PR won't pass the CI until all assertion failures have been fixed. |
Member
|
Yes, turning off assert checking was clearly a mistake. |
Contributor
|
Closing in favor of #7344 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect the testsuite to fail - and this is why we should not be doing this.