Skip to content

Comments

Revert "fix Issue 14246 - RAII - proper destruction of partially constructed objects/structs"#6899

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:revert-6816
Closed

Revert "fix Issue 14246 - RAII - proper destruction of partially constructed objects/structs"#6899
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:revert-6816

Conversation

@wilzbach
Copy link
Contributor

This reverts commit 1e755c6 (#6816).

I just want to see if Jenkins would be green then or whether there are more hidden errors.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
14246 RAII - proper destruction of partially constructed objects/structs

@wilzbach
Copy link
Contributor Author

image

At least there's an end in sight for the regression goose hunt ;-)

@UplinkCoder
Copy link
Member

@WalterBright @yebblies
ping

@MartinNowak
Copy link
Member

Ah thanks, hadn't seen it, closed in favor of #6913 which adds test cases.
BTW, can we adjust the thresholds for codecov to not complain about -0.003% changes?

@wilzbach
Copy link
Contributor Author

BTW, can we adjust the thresholds for codecov to not complain about -0.003% changes?

Nope, but see this issue for ideas:
#6879

@wilzbach wilzbach deleted the revert-6816 branch March 13, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants