skip typeinfo for struct/enum in betterC mode#6922
Merged
WalterBright merged 1 commit intodlang:masterfrom Jun 21, 2017
Merged
Conversation
Contributor
Author
|
BTW I'd also like to make it skip the opEquals generation, but I don't know where that is in the compiler and need to get back to work on my real job. Skipping that should enable slices inside structs to work too. And if someone actually does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you try to compile a -betterC thing with a struct, it gives a linker error. This skips typeinfo letting them work in the simple case.
Whereas -betterC is a "rip stuff out" hack in the first place, this little change fits right in with it. And with this, I consider -betterC to actually live up to its name - the C subset of D is actually usable now, out of the box, given the switch.