Use a proper fallback when git describe fails#6942
Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
Closed
Use a proper fallback when git describe fails#6942wilzbach wants to merge 1 commit intodlang:masterfrom
git describe fails#6942wilzbach wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Member
Contributor
Author
Thanks, Martin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to #6940 the fix from #6941 is also needed for
master, see e.g. dlang/phobos#5514I cherry-picked the same commit to keep things simple as I would like to get CircleCi working at Phobos.
CC @MartinNowak @CyberShadow
Usually
git describeshouldn't fail and if it's probably a source ball archive. Anyhow my main focus here is really fixing CircleCi - we can always change the behavior in a follow-up.