Skip to content

Comments

Use a proper fallback when git describe fails#6942

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:fix-version-master
Closed

Use a proper fallback when git describe fails#6942
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:fix-version-master

Conversation

@wilzbach
Copy link
Contributor

Due to #6940 the fix from #6941 is also needed for master, see e.g. dlang/phobos#5514

I cherry-picked the same commit to keep things simple as I would like to get CircleCi working at Phobos.

CC @MartinNowak @CyberShadow

Using VERSION without anything else seems a bit more misleading as it can then be confused with a tagged release.

Usually git describe shouldn't fail and if it's probably a source ball archive. Anyhow my main focus here is really fixing CircleCi - we can always change the behavior in a follow-up.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@MartinNowak
Copy link
Member

#6941 already went into master, I picked 89beb11 over to stable

@wilzbach wilzbach deleted the fix-version-master branch June 26, 2017 21:25
@wilzbach
Copy link
Contributor Author

I picked 89beb11 over to stable

Thanks, Martin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants