refactor: convert Obj.funcptr() to Obj.setModuleCtorDtor()#6957
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jul 3, 2017
Merged
refactor: convert Obj.funcptr() to Obj.setModuleCtorDtor()#6957dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
UplinkCoder
reviewed
Jul 2, 2017
| /*************************************** | ||
| * Stuff pointer to function in its own segment. | ||
| * Used for static ctor and dtor lists. | ||
| * Set up function to be called as static constructor on program |
Member
There was a problem hiding this comment.
Stuff pointer to function in its own segment.
This is useful information.
please keep it.
andralex
approved these changes
Jul 2, 2017
Member
|
See https://www.airs.com/blog/archives/51 @WalterBright for Info on ELF ctors/dtors. void foo() __attribute__((constructor, destructor));
void foo() {}will generate two entries, one in the BTW, I find the function name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because #6956 has some controversy, I factored out the uncontroversial bits into this one.
I.e. redo Obj.funcptr() to make its name reflective of what it does, and remove its dependency on the specifics of the identifier so it can be ported to other platforms.