Separate Initializer semantic#7007
Conversation
|
Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
@UplinkCoder any ideas why compiling druntime leads to CTFE errors? |
|
@RazvanN7 Nothing that jumps in the eye. Are you sure the constructors are getting called correctly ? |
|
@UplinkCoder you mean drop the PR? why? |
|
The code is not likely to change. |
Yep. I just copy-pasted the code and added
I disagree. Refactoring the code this way makes the code easier to read and makes packaging the compiler as a library easier |
a9fdc0f to
141c339
Compare
I can't agree more. Code is read a lot more than its written and every change that helps to improve the readability of the dmd codebase is imho very useful. @RazvanN7 Please don't stop cleaning up and refactoring the frontend. You are doing great and important work! |
64b503e to
8c849f4
Compare
|
I plan on doing Expression next. |
|
And C++ headers? |
8c849f4 to
c3ee87c
Compare
|
@ibuclaw forgot about those... done. |
This PR separates the semantic routines from the AST classes of the Initializer nodes. It is a follow-up to @yebblies 's work #5730