Skip to content

Add missing CTFloat::hash function to ctfloat.h#7016

Merged
WalterBright merged 1 commit intodlang:stablefrom
ibuclaw:ctfloat-hash
Jul 23, 2017
Merged

Add missing CTFloat::hash function to ctfloat.h#7016
WalterBright merged 1 commit intodlang:stablefrom
ibuclaw:ctfloat-hash

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jul 23, 2017

Added to D implementation in #6418

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw ibuclaw changed the base branch from master to stable July 23, 2017 11:04
@wilzbach
Copy link
Contributor

It's more than time that we generate these files.
@UplinkCoder @RazvanN7 do you remember #5082?
If using DMD as a library is too complicated, libdparse would do a fine job as well.
Is this generator on your roadmap?

@UplinkCoder
Copy link
Member

@wilzbach
Currently using the compiler as a library is infeasible.
However, I could do a c++ hdrgen switch for dmd akin to -H. Maybe -Hc ?

@wilzbach
Copy link
Contributor

Currently using the compiler as a library is infeasible.

What's missing?

However, I could do a c++ hdrgen switch for dmd akin to -H. Maybe -Hc?

Oh I am not sure that's a good idea (except you can revive @yebblies's PR). The Unix philosophy is to do one step and do it will. DMD already does a lot of things ... with a full Bugzilla list, so imho doing this in a separate tool would be better.
As mentioned, if DMD as a library isn't ready yet, it shouldn't be a big deal to do this with libdparse.
What do other people think about this @yebblies, @andralex, @ibuclaw, @WalterBright?

@WalterBright WalterBright merged commit b55864b into dlang:stable Jul 23, 2017
@ibuclaw ibuclaw deleted the ctfloat-hash branch July 23, 2017 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants