Skip to content

Comments

Fix Issue 17684 - [REG 2.062] static alias this (Part 3)#7104

Closed
JinShil wants to merge 30 commits intodlang:stablefrom
JinShil:static_alias_this_3
Closed

Fix Issue 17684 - [REG 2.062] static alias this (Part 3)#7104
JinShil wants to merge 30 commits intodlang:stablefrom
JinShil:static_alias_this_3

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 27, 2017

Followup to #7055 and #7070

The current implementation does not work for the following:

  • && and || expressions
  • ! expressions
  • return statements

This PR fixes those.

Tests were refactored to reduce redundancy and test for the features above.

WalterBright and others added 29 commits July 25, 2017 02:05
…ods mangleType, mangleIdentifier and mangleSymbol
… the type again.

This might introduce a small performance regression, but most will be compensated or even reversed by adding back reference encoding later.
…er symbol

To continue streaming into the same Outbuffer this requires removal of prefixing aliases, templates and tuples with a length that is only available when the subpart is fully encoded. The tuple terminates the entries with a 'Z' now.
CodeBuilder: convert load_localgot()
merged-on-behalf-of: Andrei Alexandrescu <andralex@users.noreply.github.com>
Merge remote-tracking branch 'upstream/mangle' into merge_mangle
merged-on-behalf-of: Martin Nowak <code@dawg.eu>
- capture expression tree as reverse polish notation
- pass scalar subtrees as single argument
- fixes Issue 10523 - don't call array op functions for short vector ops
- now left-to-right evaluated like everything else
refactor: add parseCommandLine()
merged-on-behalf-of: Martin Nowak <code@dawg.eu>
CodeBuilder: getregs(), and more
merged-on-behalf-of: Martin Nowak <code@dawg.eu>
convert array ops to library calls
merged-on-behalf-of: Walter Bright <WalterBright@users.noreply.github.com>
- use more portable xdg-open to open websites
- in accordance with std.process.browse
debian x-www-browser -> Freedesktop xdg-open
merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
Remove issue stats badge from README
merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 27, 2017

Thanks for your pull request, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
10523 Don't call array op functions for short vector ops
15831 IFTI voldemort type exploding bloat
17684 [REG 2.062] static alias this bug or incomplete implementation?

@JinShil JinShil changed the title [WIP] Fix Issue 17684 - [REG 2.062] static alias this (Part 3) Fix Issue 17684 - [REG 2.062] static alias this (Part 3) Aug 28, 2017
@JinShil
Copy link
Contributor Author

JinShil commented Aug 28, 2017

@MartinNowak (Since you reviewed the last two PRs)

This is ready to go.

@PetarKirov
Copy link
Member

The other PRs were targeted at the stable branch. Should this too? (Otherwise the changes in this PR will be released with 2.077.0, while the rest (part 1 and part 2) will be out with 2.076.0).

BTW Mike, considering how much effort you put into this feature, we may as well advertise it as new one, by adding a changelog entry ;)

@JinShil JinShil changed the base branch from master to stable August 28, 2017 14:23
@JinShil
Copy link
Contributor Author

JinShil commented Aug 28, 2017

Well, I tried to retarget stable through GitHub's interface, but it looks really bad. I'll open a new PR.

@JinShil JinShil closed this Aug 28, 2017
@PetarKirov
Copy link
Member

@JinShil after you change the target branch from GitHub's UI, you also need to rebase your local branch on top of dmd stable and then force push your local branch to GitHub.

@JinShil
Copy link
Contributor Author

JinShil commented Aug 28, 2017

Sorry @ZombineDev, I tried but Github wouldn't let me re-open because I force-pushed. My git-fu is still pretty poor.

About the changelog: I never really intended this to be a new feature. I thought it was just supposed to work that way, and if you look at the original issue, I just wanted to make the assignment symmetric. I just happened to stumble on these other issues as I started using the feature.

The issue will show up in the changelog anyway. But, I'll see about adding a special entry in the changelog if that's what everyone wants.

@JinShil
Copy link
Contributor Author

JinShil commented Aug 28, 2017

Re-opened at #7106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants