fix Issue 17787 - Add a BetterC predefined version so libraries can adapt#7132
fix Issue 17787 - Add a BetterC predefined version so libraries can adapt#7132dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
PetarKirov
left a comment
PetarKirov
left a comment
There was a problem hiding this comment.
Thanks for doing this! One minor nitpick:
| } | ||
|
|
||
| // https://issues.dlang.org/show_bug.cgi?id=17787 | ||
| version (D_betterC) |
There was a problem hiding this comment.
Since all other predefined versions prefixed by D_ are using the PascalCase naming convention, perhaps we should use D_BetterC for consistency.
There was a problem hiding this comment.
I decided that consistently calling it betterC was a better idea :-)
|
Doc pull: dlang/dlang.org#1892 |
Cherry-pick from upstream DMD, dlang/dmd#7132
Cherry-pick from upstream DMD, dlang/dmd#7132
|
Please let's make this |
|
I'd also argue that we should have per-feature versions rather than a kitchen-sink flag, where the meaning changes between compiler versions as more stuff is added to |
@klickverbot I agree. How about making a PR to do it? |
I'd rather not, as one could as well argue that every semantic change to the language should have a predefined version. Things could turn into a hopeless swamp very easily. Besides, there are very few current users of betterC and I expect it to settle down fairly quickly. |
…ency with other predefined version identifiers, like `D_NoBoundsChecks`. As discussed in dlang#7132 (comment).
@WalterBright Here it is: #7248 |
Cherry-pick from upstream DMD, dlang/dmd#7132
…ency with other predefined version identifiers, like `D_NoBoundsChecks`. As discussed in dlang/dmd#7132 (comment).
Cherry-pick from upstream DMD, dlang/dmd#7132
6 participants
No description provided.