func: Clarify traverseIndirections()#7180
Merged
WalterBright merged 1 commit intodlang:masterfrom Oct 4, 2017
Merged
Conversation
Contributor
|
Thanks for your pull request, @klickverbot! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
dnadlinger
force-pushed
the
clarify-traverse-indirections
branch
2 times, most recently
from
84d8727 to
a4be70b
Compare
This is the type-based alias analysis implementation used to allow mutable -> immutable for pure factory functions. No functional change intended.
dnadlinger
force-pushed
the
clarify-traverse-indirections
branch
from
a4be70b to
8d8ff84
Compare
Contributor
Author
|
(Fixed whitespace.) |
WalterBright
reviewed
Oct 4, 2017
| * | ||
| * This relation is not symmetric in the two arguments. For example, a | ||
| * a `const(int)` reference can point to a pre-existing `int`, but not the other | ||
| * way round. |
WalterBright
reviewed
Oct 4, 2017
| // `ta` and `tb` while avoiding cycles. Start with the original types. | ||
| return traverseIndirectionsImpl(ta, tb, null, false); | ||
| } | ||
| private bool traverseIndirectionsImpl(Type ta, Type tb, void* p, bool reversePass) |
Member
There was a problem hiding this comment.
This should be a function nested within traverseIndirections
Member
There was a problem hiding this comment.
BTW, making it a nested function also eliminates the casting of the void* parameter, which makes the function safe.
Member
|
@klickverbot I found the source of the trouble, though I am not sure how to fix it. Detailed in https://issues.dlang.org/show_bug.cgi?id=17635 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the type-based alias analysis implementation used to
allow mutable -> immutable for pure factory functions.
No functional change intended.
(@WalterBright: As per discussion in #3085 – hope this helps.)