Skip to content

win32.mak: remove unnecessary use of $(DM_HOME)#7260

Merged
dlang-bot merged 1 commit intodlang:masterfrom
rainers:rem_dm_home
Nov 4, 2017
Merged

win32.mak: remove unnecessary use of $(DM_HOME)#7260
dlang-bot merged 1 commit intodlang:masterfrom
rainers:rem_dm_home

Conversation

@rainers
Copy link
Copy Markdown
Member

@rainers rainers commented Oct 30, 2017

dmc knows its include folder through it's own version of sc.ini.

Also removed some misinformation.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Copy Markdown
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonably to me though I don't use Windows. CC @CyberShadow

@CyberShadow
Copy link
Copy Markdown
Member

I haven't used Windows in 2 years and will not have access to my Windows VM this year, sorry.

Copy link
Copy Markdown
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust @rainers' experience here. Thanks.

@dlang-bot dlang-bot merged commit 03a5b5a into dlang:master Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants