betterC: add nothrow RAII for destructors in expressions#7304
Merged
dlang-bot merged 1 commit intodlang:masterfrom Nov 15, 2017
Merged
betterC: add nothrow RAII for destructors in expressions#7304dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
WalterBright
force-pushed
the
betterC-nothrow
branch
from
64f3f27 to
944cf5b
Compare
andralex
approved these changes
Nov 14, 2017
Member
andralex
left a comment
andralex
left a comment
There was a problem hiding this comment.
let's get back to improving this real soon thx
| * the best we can do. | ||
| * Nothrow needs to be tracked at the Statement level. | ||
| */ | ||
| return global.params.betterC; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a start on adding RAII support for -betterC by doing it the old-fashioned way - assume a nothrow environment. It's the way C++ worked before exceptions were added to the language.
Adding this support for statement level RAII comes later.
This also suggests a significant optimization for regular D if nothrow is tracked at the statement level rather than at the function level.