Issue 9631 - Error message not using fully qualified name (part 3)

[ntrel]

Disambiguate cast error messages.

@JinShil another follow up from #7405.

[dlang-bot]

Thanks for your pull request, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close	Bugzilla	Description
✗	9631	Error message not using fully qualified name when appropriate.

[PetarKirov]

cast(tem!().S[])(af[])

[PetarKirov]

Actually, you probably want to fix the error message on line 1590 as well: https://github.com/ntrel/dmd/blob/4e86c34dbb0e2032d0dd55bbc30062b9950475dc/src/dmd/dcast.d#L1590

[ntrel]

Using af[] doesn't cause an error.

The sizes don't line up error only happens when if (tob.ty == Tarray && t1b.ty == Tsarray) is hit, a few lines before, which IIUC would mean toChars is never the same for each type (one is a static array, one not), so a fix is redundant.

[ntrel]

Or this simple toAutoQualChars fix is redundant rather. It would be good to show the qualification for S[1] vs S[] too, but I'm not sure how to best to do that. Same goes for S() and S, expression vs type, toChars is different.