Move Compiler structure to own module.#7457
Conversation
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
I don't see any reason not to do this, but it could probably use more substance to motivate it. What's preventing moving |
If someone from core maintainers says OK, then I'll do the work and move functions across. |
|
I like that idea. Should the new file be added to any makefiles? |
Right, once there's actually data in the module that needs compiling. :-) |
It should still be added to the list of modules right now, rather than placing the burden on whoever maybe just makes a small change to the module in the future. |
wilzbach
left a comment
There was a problem hiding this comment.
I am hugely in favor of this. It would be very helpful for the DMD as a library project.
|
I didn't know there already was a PR doing a similar thing : #7524 . Any way seems like we need this so we should merge one or the other. |
Well merge this then as it's one better. ;-) In any case, point is that nothing in mars.d is useable in other compilers. |
|
Added to make files, and split out into own header. |
Thanks! Looks good! It seems that we are all unanimously in favor of this? |
|
I hope so, so that I can start populating it. |
And I propose that this should be the home of
genCmain(which closes issue 15374), as well as other free functions called by the frontend, but implemented by the driver/backend in a way that isn't compatible across compiler implementations.