Skip to content

Move Compiler structure to own module.#7457

Merged
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:compiler
Dec 27, 2017
Merged

Move Compiler structure to own module.#7457
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:compiler

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Dec 17, 2017

And I propose that this should be the home of genCmain (which closes issue 15374), as well as other free functions called by the frontend, but implemented by the driver/backend in a way that isn't compatible across compiler implementations.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@JinShil
Copy link
Contributor

JinShil commented Dec 19, 2017

I don't see any reason not to do this, but it could probably use more substance to motivate it. What's preventing moving genCmain now?

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 20, 2017

I don't see any reason not to do this, but it could probably use more substance to motivate it. What's preventing moving genCmain now?

If someone from core maintainers says OK, then I'll do the work and move functions across.

@jacob-carlborg
Copy link
Contributor

I like that idea. Should the new file be added to any makefiles?

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 20, 2017

Should the new file be added to any makefiles?

Right, once there's actually data in the module that needs compiling. :-)

@dnadlinger
Copy link
Contributor

Right, once there's actually data in the module that needs compiling. :-)

It should still be added to the list of modules right now, rather than placing the burden on whoever maybe just makes a small change to the module in the future.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hugely in favor of this. It would be very helpful for the DMD as a library project.

@RazvanN7
Copy link
Contributor

I didn't know there already was a PR doing a similar thing : #7524 . Any way seems like we need this so we should merge one or the other.

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 26, 2017

Any way seems like we need this so we should merge one or the other.

Well merge this then as it's one better. ;-)

In any case, point is that nothing in mars.d is useable in other compilers.

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 26, 2017

Added to make files, and split out into own header.

@wilzbach
Copy link
Contributor

Added to make files, and split out into own header.

Thanks! Looks good! It seems that we are all unanimously in favor of this?

@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 27, 2017

I hope so, so that I can start populating it.

@dlang-bot dlang-bot merged commit 6e4e550 into dlang:master Dec 27, 2017
@ibuclaw ibuclaw deleted the compiler branch December 27, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants