Skip to content

(Option 2) in win32.mak, default HOST_DC to dmd#7468

Closed
marler8997 wants to merge 1 commit intodlang:masterfrom
marler8997:fix_windows_mak2
Closed

(Option 2) in win32.mak, default HOST_DC to dmd#7468
marler8997 wants to merge 1 commit intodlang:masterfrom
marler8997:fix_windows_mak2

Conversation

@marler8997
Copy link
Copy Markdown
Contributor

No description provided.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@marler8997 marler8997 changed the title in win32.mak, default HOST_DC to dmd (Option 2) in win32.mak, default HOST_DC to dmd Dec 19, 2017
@wilzbach
Copy link
Copy Markdown
Contributor

wilzbach commented Dec 19, 2017

Your tests failed on CircleCI

FYI: this is due to the recent upgrade of CircleCi to 2.0.
Rebasing to master will fix the CircleCi errors.

edit: not that it would be required for this PR, but it's always nice to see only green checks.

@marler8997 marler8997 force-pushed the fix_windows_mak2 branch 2 times, most recently from 159796c to 272f691 Compare December 19, 2017 17:01
@andralex
Copy link
Copy Markdown
Member

andralex commented Jan 2, 2018

This is option 2 to...?

@wilzbach
Copy link
Copy Markdown
Contributor

wilzbach commented Jan 2, 2018

#7467

@JinShil
Copy link
Copy Markdown
Contributor

JinShil commented Jan 6, 2018

Choosing Option 1: #7467

@JinShil JinShil closed this Jan 6, 2018
@marler8997 marler8997 deleted the fix_windows_mak2 branch February 21, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants