Skip to content

Revert "fix Issue 18053 - Use stdint.h mangling for int64_t/uint64_t when man…"#7505

Closed
wilzbach wants to merge 1 commit intomasterfrom
revert-7416-fix18053
Closed

Revert "fix Issue 18053 - Use stdint.h mangling for int64_t/uint64_t when man…"#7505
wilzbach wants to merge 1 commit intomasterfrom
revert-7416-fix18053

Conversation

@wilzbach
Copy link
Contributor

Reverts #7416 due to the Travis error on OSX, see e.g. https://travis-ci.org/dlang/dmd/jobs/320910100

Undefined symbols for architecture x86_64:
  "mem_malloc(unsigned long long)", referenced from:
      array_toDarray(Type*, elem*) in dmd.o
      toElem::ToElemVisitor::visit(StringExp*) in dmd.o
  "symboldata(unsigned long, unsigned int)", referenced from:
      el_ptr(Symbol*) in backend.a(el.o)
      el_convstring(elem*) in backend.a(el.o)
      out_readonly_sym(unsigned int, void*, int) in backend.a(out.o)
      Obj::sym_cdata(unsigned int, char*, int) in backend.a(machobj.o)
  "_align(unsigned long, unsigned long)", referenced from:
      codgen(Symbol*) in backend.a(cgcod.o)
      stackoffsets(int) in backend.a(cgcod.o)
      outjmptab(block*) in backend.a(cod3.o)
      outswitab(block*) in backend.a(cod3.o)
      type_paramsize(TYPE*) in backend.a(type.o)
      alignOffset(int, unsigned long) in backend.a(out.o)
      out_readonly_sym(unsigned int, void*, int) in backend.a(out.o)
      ...
  "ispow2(unsigned long long)", referenced from:
      asmSemantic(AsmStatement*, Scope*) in dmd.o
  "outthunk(Symbol*, Symbol*, unsigned int, unsigned int, unsigned long long, int, unsigned long long)", referenced from:
      toThunkSymbol(FuncDeclaration*, int) in dmd.o
  "Obj::ehtables(Symbol*, unsigned long long, Symbol*)", referenced from:
      except_gentables() in dmd.o
  "DtBuilder::size(unsigned long long)", referenced from:
      Initializer_toDt::InitToDt::visit(ArrayInitializer*) in dmd.o
      Expression_toDt::ExpToDt::visit(StringExp*) in dmd.o
      Expression_toDt::ExpToDt::visit(ArrayLiteralExp*) in dmd.o
      cpp_type_info_ptr_toDt(ClassDeclaration*, DtBuilder*) in dmd.o
      _D3dmd4todt11membersToDtFCQy9aggregate20AggregateDeclarationCQCh7backend2dt9DtBuilderPSQDh4root5array__T5ArrayTCQEg10expression10ExpressionZQBkmCQFn6dclass16ClassDeclarationPPPSQGtQBg9BaseClassZv in dmd.o
      TypeInfoDtVisitor::visit(TypeInfoDeclaration*) in dmd.o
      TypeInfoDtVisitor::visit(TypeInfoConstDeclaration*) in dmd.o
      ...
  "DtBuilder::repeat(dt_t*, unsigned long long)", referenced from:
      Initializer_toDt::InitToDt::visit(ArrayInitializer*) in dmd.o
      _D3dmd4todt11membersToDtFCQy9aggregate20AggregateDeclarationCQCh7backend2dt9DtBuilderPSQDh4root5array__T5ArrayTCQEg10expression10ExpressionZQBkmCQFn6dclass16ClassDeclarationPPPSQGtQBg9BaseClassZv in dmd.o
      Type_toDt::TypeToDt::visit(TypeVector*) in dmd.o
      Type_toDt::TypeToDt::visit(TypeSArray*) in dmd.o
      _D3dmd4todt8toDtElemFCQu5mtype10TypeSArrayCQBp7backend2dt9DtBuilderCQCo10expression10ExpressionZv in dmd.o
  "Outbuffer::write(void const*, unsigned long long)", referenced from:
      Outbuffer::write(Outbuffer*) in dmd.o
  "Outbuffer::enlarge(unsigned long long)", referenced from:
      Outbuffer::reserve(unsigned long long) in dmd.o
      Outbuffer::writeByte(int) in dmd.o
      Outbuffer::writeWord(int) in dmd.o
      Outbuffer::writeShort(int) in dmd.o
      Outbuffer::writeChar(int) in dmd.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error: linker exited with status 1

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Description
18053 Use stdint.h mangling for int64_t/uint64_t when mangling D long/ulong

@wilzbach
Copy link
Contributor Author

(opened this PR to see whether this unbreaks Travis)

@WalterBright
Copy link
Member

Perhaps a PR to fix the declarations would be better than reversion.

@wilzbach
Copy link
Contributor Author

Perhaps a PR to fix the declarations would be better than reversion.

I gave it a first try at #7519, but could we please be a bit more careful in the future when merging such breaking changes, so that at least our own CIs still work afterwards? Don't we all hate the red cross on the CI status page? 😉

@wilzbach wilzbach closed this Dec 25, 2017
@wilzbach wilzbach deleted the revert-7416-fix18053 branch December 25, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants