Remove unneeded clang warning flags.#7517
Merged
dlang-bot merged 3 commits intodlang:masterfrom Dec 27, 2017
Merged
Conversation
ibuclaw
requested review from
CyberShadow,
MartinNowak and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
JinShil
approved these changes
Dec 25, 2017
wilzbach
approved these changes
Dec 26, 2017
wilzbach
reviewed
Dec 27, 2017
| -std=gnu++98 | ||
| endif | ||
| # Clang Specific | ||
| ifeq ($(CXX_KIND), clang++) |
Contributor
There was a problem hiding this comment.
FYI g++ supports this flag too (and actually my local clang++ doesn't trigger a warning without it). In any case I don't think there's any harm in always letting -xc++ be part of the CXXFLAGS.
Member
Author
There was a problem hiding this comment.
I must have been doing something weird the first time I ran make with cxx=clang because I couldn't reproduce after the a couple runs, maybe I added or removed something before resetting the branch, such as deprecation warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed version of #7515