ispow2: change parameter to uint64_t#7522
Merged
dlang-bot merged 1 commit intodlang:masterfrom Dec 27, 2017
Merged
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Member
Author
|
Of course, this doesn't work because the bootstrap dmd uses the old scheme. Sigh. |
Member
Author
|
Worked around by having a separate |
wilzbach
approved these changes
Dec 27, 2017
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
I assume we can get rid of this duplication with the "D-ification" of the backend soon.
| * If c is a power of 2, return that power else -1. | ||
| */ | ||
|
|
||
| private int ispow2(uint c) |
Contributor
There was a problem hiding this comment.
D shouldn't be about duplicating code :(
Member
Author
There was a problem hiding this comment.
There's a lot of hackish code that the conversion to D will eliminate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.