Peel off outer ForwardingStatement after running semantic#7526
Merged
dlang-bot merged 3 commits intodlang:masterfrom Dec 27, 2017
Merged
Peel off outer ForwardingStatement after running semantic#7526dlang-bot merged 3 commits intodlang:masterfrom
dlang-bot merged 3 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
ibuclaw
force-pushed
the
peelfs
branch
2 times, most recently
from
6ea8d0b to
f4d1656
Compare
Member
Author
|
This should be ready for review. @tgehr |
tgehr
approved these changes
Dec 26, 2017
src/dmd/blockexit.d
Outdated
| { | ||
| result = BE.fallthru; | ||
| } | ||
| assert(0); |
Contributor
There was a problem hiding this comment.
I guess this can be removed, as the Statement overload will assert anyway.
Contributor
|
Looks good to me. Thanks for taking this! |
PetarKirov
approved these changes
Dec 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI - @tgehr
As it has no use outside of semantic analysis.