UDAs for function arguments by wilzbach · Pull Request #7576 · dlang/dmd

wilzbach · 2018-01-02T01:30:09Z

#4783 revived from the dead.
See dlang/DIPs#105 for a respective DIP.

Official spelling is "user-defined attributes".

dlang-bot · 2018-01-02T01:30:10Z

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#7576"

wilzbach · 2018-01-02T04:38:43Z

Jenkins failure looks unrelated: dlang/ci#105

wilzbach · 2018-01-02T04:40:38Z

src/dmd/astbase.d

            this.type = type;
            this.ident = ident;
            this.defaultArg = defaultArg;
+            this.userAttribDecl = userAttribDecl;


@RazvanN7 do you have any plans on removing the giant code duplication in astbase?

jacob-carlborg · 2018-01-02T08:27:39Z

Will this work for template parameters?

wilzbach · 2018-01-02T09:22:57Z

Will this work for template parameters?

Not this version.
AFAICT is the proposed DIP also only about parameter attributes (and attaching attributes to enums).
It does work with template d parameters - I just added test cases for that.

mathias-lang-sociomantic · 2018-01-02T11:39:19Z

test/fail_compilation/udaparams.d

+
+void wrongAttr1(@safe int);
+void wrongAttr2(@safe void function());
+void wrongAttr3(@safe void delegate());


That isn't going to be confusing at all :D

Those are invalid attributes, so it shouldn't be too big of a problem.

mathias-lang-sociomantic · 2018-01-02T11:41:18Z

test/runnable/uda.d

+}
+
+/************************************************/
+


Probably could use a test with a tuple as well

jacob-carlborg · 2018-01-02T17:12:21Z

It does work with template d parameters - I just added test cases for that.

@wilzbach that do you mean with "template d parameters"?

skl131313 · 2018-01-03T01:54:25Z

src/dmd/astbase.d

        extern (D) alias ForeachDg = int delegate(size_t idx, Parameter param);

-        final extern (D) this(StorageClass storageClass, Type type, Identifier ident, Expression defaultArg)
+        final extern (D) this(StorageClass storageClass, Type type, Identifier ident, Expression defaultArg, UserAttributeDeclaration userAttribDecl)


Expression defaultArg, UserAttributeDeclaration userAttribDecl = null)

Giving this a default value would save on a lot of code edits that just add a null as the last parameter. Not sure if default values are being avoided here on purpose or not.

AFAICT is the prevalent coding style in the DMD source code to prefer explicitness.

John-Colvin · 2018-01-03T23:03:23Z

I'm trying to get a hold on the scope of this PR.
Can I do this?

auto a(int x)(void function(@(x) int) f);
auto b = a((@(2) int){ });

skl131313 · 2018-01-04T02:17:56Z

@John-Colvin
Not I don't think that's possible with the current implementation, also not sure if that is desired.

wilzbach · 2018-05-08T00:33:49Z

Finally got around submitting the dlang.org PR: dlang/dlang.org#2363

jacob-carlborg · 2018-05-08T11:43:00Z

test/runnable/uda.d

+    static assert(is(ParameterUDA!(3, test14x)[0] == Test14UDA4!"3"));
+}
+
+void test15x(@(20) void delegate(int) @safe dg)


What about the parameters on delegates, are UDAs on those supported? Either way I think it's worth having a test case, showing either that it works or that it doesn't work.

Added the tests below.

IgorStepanov · 2018-06-25T01:01:04Z

Ping. What status of that?

jacob-carlborg · 2018-06-25T10:14:19Z

Ping. What status of that?

I asked for some more tests, which I don't think has been added. Not sure what else.

@wilzbach ping.

wilzbach · 2018-06-27T11:38:44Z

I asked for some more tests, which I don't think has been added.

Sorry. I haven't found much time for this, but now managed to add these tests. See test15y and test15z.

Not sure what else.

Same here.

jacob-carlborg · 2018-06-27T13:08:49Z

changelog/uda-function-arguments.dd

+{
+    static assert([__traits(getAttributes, a)] == [22]);
+}
+---


Perhaps include an example of how to get the UDAs of a parameter from outside of a function. Or should that be left as an exercise for the reader 😃.

That's a bit more complicated and I think we will provide an interface in std.traits anyhow.

jacob-carlborg · 2018-06-27T13:24:33Z

Tests for the following could be added:

Lambdas, both with and without parentheses: alias a = @(3) b => 1 + 2 and alias b = (@(3) c, @(4) d) => 1 + 2 and usage like: map!(@(3) a => 1 + 2)
Using a delegate with inferred parameter type: foo((@(3) a) { return 1 + 2; })
Template parameter: void foo(@(3) T)(T t)

wilzbach · 2018-06-30T13:31:41Z

Lambdas, both with and without parentheses: alias a = @(3) b => 1 + 2 and alias b = (@(3) c, @(4) d) => 1 + 2 and usage like: map!(@(3) a => 1 + 2)

Only the latter was supported (i.e. with parentheses). I added support for alias a = @(3) b => 1 + 2.
Though I'm not sure that alias a = @(3) b => 1 + 2 will be used in practice.
I added the tests to test19, but I'm not sure whether there's currently a way to query the attributes.

Using a delegate with inferred parameter type: foo((@(3) a) { return 1 + 2; })

Added to test20.

Template parameter: void foo(@(3) T)(T t)

That's not supported as of now. I'm not sure it's that useful, but if people run into use cases for it, it could always be added?
(I still added it to fail_compilation)

jacob-carlborg · 2018-06-30T13:50:15Z

That's not supported as of now

I’m not asking for adding new functionality, just to add tests that shows it’s either compiles or fails to compile.

nordlow · 2018-07-01T11:14:56Z

Cool. I wonder if Andrei will have use of this in his complexity library...

I notified him and he answered that this PR indeed will make it more powerful!

wilzbach requested a review from WalterBright as a code owner January 2, 2018 01:30

This was referenced Jan 2, 2018

[WIP] Enum and Function Parameter Attributes. dlang/DIPs#105

Closed

UDAs for function arguments #4783

Closed

dlang-bot added the Review:Needs Work label Jan 2, 2018

wilzbach force-pushed the uda-for-function-arguments branch from 9ad1931 to 2600eaf Compare January 2, 2018 03:55

wilzbach removed the Review:Needs Work label Jan 2, 2018

wilzbach commented Jan 2, 2018

View reviewed changes

JinShil added the Review:Pending DIP Approval label Jan 2, 2018

mathias-lang-sociomantic reviewed Jan 2, 2018

View reviewed changes

skl131313 reviewed Jan 3, 2018

View reviewed changes

dlang-bot added the Review:Needs Rebase label Jan 8, 2018

wilzbach force-pushed the uda-for-function-arguments branch from fb14fa9 to d1b5b2d Compare January 8, 2018 13:28

dlang-bot added Review:Needs Work and removed Review:Needs Rebase labels Jan 8, 2018

wilzbach force-pushed the uda-for-function-arguments branch from d1b5b2d to 39718f6 Compare January 17, 2018 23:51

wilzbach requested review from dnadlinger and ibuclaw as code owners January 17, 2018 23:51

dlang-bot removed the Review:Needs Work label Jan 17, 2018

dlang-bot added Review:Needs Rebase Review:Needs Work labels Jan 31, 2018

skl131313 mentioned this pull request Feb 22, 2018

fix Issue 13855 - multi-module selective import statements #6589

Merged

wilzbach mentioned this pull request Feb 22, 2018

Revert "fix Issue 13855 - multi-module selective import statements" #7939

Merged

wilzbach force-pushed the uda-for-function-arguments branch from 39718f6 to 9b621d6 Compare March 20, 2018 13:25

wilzbach force-pushed the uda-for-function-arguments branch from 16d3bff to 75b1c7c Compare April 2, 2018 23:52

wilzbach force-pushed the uda-for-function-arguments branch from 75b1c7c to e3d47bb Compare May 4, 2018 16:33

wilzbach requested a review from Geod24 as a code owner May 4, 2018 16:33

wilzbach force-pushed the uda-for-function-arguments branch 3 times, most recently from 4679f23 to 1656137 Compare May 7, 2018 23:35

wilzbach mentioned this pull request May 8, 2018

[spec] Add UDAs for parameters dlang/dlang.org#2363

Merged

jacob-carlborg suggested changes May 8, 2018

View reviewed changes

JinShil mentioned this pull request Jun 1, 2018

Fix Issue 9701 - allow UDAs to be attached to enum values #8319

Closed

wilzbach force-pushed the uda-for-function-arguments branch 3 times, most recently from 3a69876 to c012027 Compare June 27, 2018 11:37

jacob-carlborg reviewed Jun 27, 2018

View reviewed changes

UDAs for function arguments

0ef6f63

wilzbach force-pushed the uda-for-function-arguments branch from c012027 to 0ef6f63 Compare June 30, 2018 12:00

Support UDAs for single-parameter alias declarations

1283177

jacob-carlborg approved these changes Jun 30, 2018

View reviewed changes

jacob-carlborg added the Merge:auto-merge label Jun 30, 2018

wilzbach closed this Jun 30, 2018

wilzbach reopened this Jun 30, 2018

dlang-bot merged commit d1e803f into dlang:master Jun 30, 2018

wilzbach deleted the uda-for-function-arguments branch July 1, 2018 23:26

		}

		/************************************************/

Uh oh!

Comments

Conversation

wilzbach commented Jan 2, 2018

Uh oh!

dlang-bot commented Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bugzilla references

Testing this PR locally

Uh oh!

wilzbach commented Jan 2, 2018

Uh oh!

wilzbach Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacob-carlborg commented Jan 2, 2018

Uh oh!

wilzbach commented Jan 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skl131313 Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacob-carlborg commented Jan 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

John-Colvin commented Jan 3, 2018

Uh oh!

skl131313 commented Jan 4, 2018

Uh oh!

wilzbach commented May 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IgorStepanov commented Jun 25, 2018

Uh oh!

jacob-carlborg commented Jun 25, 2018

Uh oh!

wilzbach commented Jun 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacob-carlborg commented Jun 27, 2018

Uh oh!

wilzbach commented Jun 30, 2018

Uh oh!

jacob-carlborg commented Jun 30, 2018

Uh oh!

nordlow commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

dlang-bot commented Jan 2, 2018 •

edited

Loading

wilzbach Jan 2, 2018 •

edited

Loading

skl131313 Jan 2, 2018 •

edited

Loading

nordlow commented Jul 1, 2018 •

edited

Loading