Skip to content

fixup #7607 - set const the helpers in the cpp header too#7609

Merged
dlang-bot merged 1 commit intomasterfrom
unknown repository
Jan 5, 2018
Merged

fixup #7607 - set const the helpers in the cpp header too#7609
dlang-bot merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 5, 2018

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ghost ghost requested a review from WalterBright as a code owner January 5, 2018 12:04
@PetarKirov
Copy link
Member

Since those methods are non-virtual you don't strictly need to update the C++ headers, but it's a nice improvement for the C++ header clients nonetheless.

@dlang-bot dlang-bot merged commit 5b26410 into dlang:master Jan 5, 2018
@ghost ghost deleted the cppheader-const branch January 5, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants