Group scattered AST visitors into a visitors package

dub.sdl

@@ -43,9 +43,12 @@ subPackage {
   sourceFiles \
     "src/dmd/astbase.d" \
     "src/dmd/parse.d" \
-    "src/dmd/transitivevisitor.d" \
-    "src/dmd/permissivevisitor.d" \
-    "src/dmd/strictvisitor.d"
+    "src/dmd/visitor/parse_time.d" \
+    "src/dmd/visitor/permissive.d" \
+    "src/dmd/visitor/semantic.d" \
+    "src/dmd/visitor/stoppable.d" \
+    "src/dmd/visitor/strict.d" \
+    "src/dmd/visitor/transitive.d"
 
   dependency "dmd:lexer" version="*"
 }

src/dmd/aggregate.d

@@ -33,7 +33,7 @@ import dmd.mtype;
 import dmd.semantic2;
 import dmd.semantic3;
 import dmd.tokens;
-import dmd.visitor;
+import dmd.visitor.semantic;
 
 enum Sizeok : int
 {
@@ -737,7 +737,7 @@ extern (C++) abstract class AggregateDeclaration : ScopeDsymbol
         return this;
     }
 
-    override void accept(Visitor v)
+    override void accept(SemanticVisitor v)
     {
         v.visit(this);
     }

src/dmd/aggregate.h

@@ -146,7 +146,7 @@ class AggregateDeclaration : public ScopeDsymbol
     Symbol *sinit;
 
     AggregateDeclaration *isAggregateDeclaration() { return this; }
-    void accept(Visitor *v) { v->visit(this); }
+    void accept(SemanticVisitor *v) { v->visit(this); }
 };
 
 struct StructFlags
@@ -195,7 +195,7 @@ class StructDeclaration : public AggregateDeclaration
     bool isPOD();
 
     StructDeclaration *isStructDeclaration() { return this; }
-    void accept(Visitor *v) { v->visit(this); }
+    void accept(SemanticVisitor *v) { v->visit(this); }
 };
 
 class UnionDeclaration : public StructDeclaration
@@ -205,7 +205,7 @@ class UnionDeclaration : public StructDeclaration
     const char *kind() const;
 
     UnionDeclaration *isUnionDeclaration() { return this; }
-    void accept(Visitor *v) { v->visit(this); }
+    void accept(SemanticVisitor *v) { v->visit(this); }
 };
 
 struct BaseClass
@@ -321,7 +321,7 @@ class ClassDeclaration : public AggregateDeclaration
     Symbol *vtblsym;
 
     ClassDeclaration *isClassDeclaration() { return (ClassDeclaration *)this; }
-    void accept(Visitor *v) { v->visit(this); }
+    void accept(SemanticVisitor *v) { v->visit(this); }
 };
 
 class InterfaceDeclaration : public ClassDeclaration
@@ -337,7 +337,7 @@ class InterfaceDeclaration : public ClassDeclaration
     bool isCOMinterface() const;
 
     InterfaceDeclaration *isInterfaceDeclaration() { return this; }
-    void accept(Visitor *v) { v->visit(this); }
+    void accept(SemanticVisitor *v) { v->visit(this); }
 };
 
 #endif /* DMD_AGGREGATE_H */

src/dmd/aliasthis.d

@@ -23,7 +23,7 @@ import dmd.identifier;
 import dmd.mtype;
 import dmd.opover;
 import dmd.tokens;
-import dmd.visitor;
+import dmd.visitor.semantic;
 
 /***********************************************************
  * alias ident this;
@@ -55,7 +55,7 @@ extern (C++) final class AliasThis : Dsymbol
         return this;
     }
 
-    override void accept(Visitor v)
+    override void accept(SemanticVisitor v)
     {
         v.visit(this);
     }

src/dmd/aliasthis.h

@@ -29,7 +29,7 @@ class AliasThis : public Dsymbol
     Dsymbol *syntaxCopy(Dsymbol *);
     const char *kind() const;
     AliasThis *isAliasThis() { return this; }
-    void accept(Visitor *v) { v->visit(this); }
+    void accept(SemanticVisitor *v) { v->visit(this); }
 };
 
 #endif

src/dmd/apply.d

@@ -15,7 +15,7 @@ module dmd.apply;
 import dmd.arraytypes;
 import dmd.dtemplate;
 import dmd.expression;
-import dmd.visitor;
+import dmd.visitor.stoppable;
 
 /**************************************
  * An Expression tree walker that will visit each Expression e in the tree,

src/dmd/argtypes.d

@@ -18,7 +18,7 @@ import core.checkedint;
 import dmd.declaration;
 import dmd.globals;
 import dmd.mtype;
-import dmd.visitor;
+import dmd.visitor.semantic;
 
 /****************************************************
  * This breaks a type down into 'simpler' types that can be passed to a function
@@ -35,9 +35,9 @@ import dmd.visitor;
  */
 TypeTuple toArgTypes(Type t)
 {
-    extern (C++) final class ToArgTypes : Visitor
+    extern (C++) final class ToArgTypes : SemanticVisitor
     {
-        alias visit = Visitor.visit;
+        alias visit = SemanticVisitor.visit;
     public:
         TypeTuple result;
 

src/dmd/arrayop.d

@@ -27,7 +27,7 @@ import dmd.mtype;
 import dmd.root.outbuffer;
 import dmd.statement;
 import dmd.tokens;
-import dmd.visitor;
+import dmd.visitor.semantic;
 
 /**********************************************
  * Check that there are no uses of arrays without [].
@@ -175,9 +175,9 @@ extern (C++) Expression arrayOp(BinAssignExp e, Scope* sc)
  */
 private void buildArrayOp(Scope* sc, Expression e, Objects* tiargs, Expressions* args)
 {
-    extern (C++) final class BuildArrayOpVisitor : Visitor
+    extern (C++) final class BuildArrayOpVisitor : SemanticVisitor
     {
-        alias visit = Visitor.visit;
+        alias visit = SemanticVisitor.visit;
         Scope* sc;
         Objects* tiargs;
         Expressions* args;