Turn .ptr deprecation into an error by wilzbach · Pull Request #7688 · dlang/dmd

wilzbach · 2018-01-12T22:08:41Z

This was scheduled to happen in 2.073 - we really need a file or wiki to list
these things, s.t. they aren't forgotten.

I'm abusing auto-tester for testing as due to -fPIC I still
can't run the testsuite locally.

dlang-bot · 2018-01-12T22:08:42Z

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

quickfur · 2018-01-12T22:59:11Z

LGTM

ibuclaw · 2018-01-12T23:21:46Z

finger hovers on merge button

JinShil · 2018-01-13T00:28:51Z

Why is this labeled "WIP"?

ibuclaw · 2018-01-13T00:30:44Z

I assume because @wilzbach can't test locally, so using ci to tell him/us what breaks with this change.

I'll block on missing changelog anyhow.

ibuclaw

Changelog entry

JinShil · 2018-01-13T00:44:22Z

Curious that this didn't require a change to any test cases, yet coverage shows it's covered. 🤔

ibuclaw · 2018-01-13T00:47:07Z

The tests are likely fail_compilation with -de. They don't need that switch anymore.

wilzbach · 2018-01-13T03:29:56Z

I assume because @wilzbach can't test locally, so using ci to tell him/us what breaks with this change.

Yeah, I often patch the test suite, but sometimes I'm in a hurry.
(reminder to myself: I should really look into getting the -fPIC PRs merged)

Curious that this didn't require a change to any test cases, yet coverage shows it's covered. 🤔

Found the test.

I'll block on missing changelog anyhow.

Added.
(Just in case someone didn't know this, the rendered changelog can be previewed at DAutoTest.)

jacob-carlborg · 2018-01-13T09:59:59Z

.ptr can still be used in @system code? If that's the case, is it worth mentioning explicitly in the changelog?

wilzbach · 2018-01-13T10:06:35Z

If that's the case, is it worth mentioning explicitly in the changelog?

I didn't judge it as important enough, because it's more or less obvious, but that you are wondering about it, is reason enough to include it (I just did so).

JinShil · 2018-01-13T11:40:20Z

test/fail_compilation/test11176.d

+REQUIRED_ARGS:
 ---
 fail_compilation/test11176.d(12): Deprecation: b.ptr cannot be used in @safe code, use &b[0] instead
 fail_compilation/test11176.d(16): Deprecation: b.ptr cannot be used in @safe code, use &b[0] instead


This isn't making any sense to me. Why are the tests passing? The output of this test should be

Error: `b.ptr` cannot be used in `@safe` code, use `&b[0]` instead

There is no TEST_OUTPUT in the comment, and so the output is not tested.

Excellent catch - the test helped me to realize that there was another Deprecation message that needed maintenance (i.e. the one for dynamic arrays).

Somp'n wrong here

ibuclaw · 2018-01-13T18:29:15Z

I'm going to say all good to go. @JinShil ?

ibuclaw · 2018-01-13T18:29:48Z

src/dmd/mtype.d

-                e.deprecation("`%s.ptr` cannot be used in `@safe` code, use `&%s[0]` instead", e.toChars(), e.toChars());
-                // return new ErrorExp();
+                e.error("`%s.ptr` cannot be used in `@safe` code, use `&%s[0]` instead", e.toChars(), e.toChars());
+                 return new ErrorExp();


Funny whitespace

JinShil

Just waiting on whitespace fix. I really need to figure out how to do such changes as part of reviewing/merging.

JinShil · 2018-01-14T00:39:33Z

Fixed whitespace with pr_push. Thanks @wilzbach!

wilzbach added the Review:WIP Work In Progress - not ready for review or pulling label Jan 12, 2018

wilzbach mentioned this pull request Jan 12, 2018

highlight mtype.d error messages #7683

Merged

ibuclaw approved these changes Jan 12, 2018

View reviewed changes

JinShil previously approved these changes Jan 13, 2018

View reviewed changes

ibuclaw requested changes Jan 13, 2018

View reviewed changes

JinShil added the Review:Needs Changelog A changelog entry needs to be added to /changelog label Jan 13, 2018

wilzbach force-pushed the maintainence branch from fee7832 to 2f05e0a Compare January 13, 2018 03:26

wilzbach removed the Review:Needs Changelog A changelog entry needs to be added to /changelog label Jan 13, 2018

wilzbach removed the Review:WIP Work In Progress - not ready for review or pulling label Jan 13, 2018

wilzbach force-pushed the maintainence branch from 2f05e0a to 71c0a91 Compare January 13, 2018 03:33

ibuclaw added the Merge:auto-merge label Jan 13, 2018

ibuclaw approved these changes Jan 13, 2018

View reviewed changes

wilzbach closed this Jan 13, 2018

wilzbach reopened this Jan 13, 2018

wilzbach removed the Merge:auto-merge label Jan 13, 2018

wilzbach force-pushed the maintainence branch from 71c0a91 to 8502689 Compare January 13, 2018 10:04

JinShil reviewed Jan 13, 2018

View reviewed changes

wilzbach force-pushed the maintainence branch from 8502689 to 4e5c53f Compare January 13, 2018 17:28

ibuclaw requested changes Jan 13, 2018

View reviewed changes

JinShil approved these changes Jan 13, 2018

View reviewed changes

Turn .ptr deprecation into an error

821b086

JinShil force-pushed the maintainence branch from 10fc109 to 821b086 Compare January 14, 2018 00:38

JinShil added the Merge:auto-merge label Jan 14, 2018

dlang-bot merged commit 5ff13b9 into dlang:master Jan 14, 2018

wilzbach deleted the maintainence branch January 14, 2018 04:49

wilzbach mentioned this pull request Jan 14, 2018

Always checks out upstream/master (instead of the PR branch) dlang/ci#120

Closed

wilzbach mentioned this pull request Jan 29, 2018

Fix Issue 18279 - rt.util.utf does not properly reserve buffer in toUTF16/toUTF16z dlang/druntime#2053

Merged

Uh oh!

Conversation

wilzbach commented Jan 12, 2018

Uh oh!

dlang-bot commented Jan 12, 2018

Bugzilla references

Uh oh!

quickfur commented Jan 12, 2018

Uh oh!

ibuclaw commented Jan 12, 2018

Uh oh!

JinShil commented Jan 13, 2018

Uh oh!

ibuclaw commented Jan 13, 2018

Uh oh!

ibuclaw left a comment

Choose a reason for hiding this comment

Uh oh!

JinShil commented Jan 13, 2018

Uh oh!

ibuclaw commented Jan 13, 2018

Uh oh!

wilzbach commented Jan 13, 2018

Uh oh!

jacob-carlborg commented Jan 13, 2018

Uh oh!

wilzbach commented Jan 13, 2018

Uh oh!

JinShil Jan 13, 2018

Choose a reason for hiding this comment

Uh oh!

ibuclaw Jan 13, 2018

Choose a reason for hiding this comment

Uh oh!

wilzbach Jan 13, 2018

Choose a reason for hiding this comment

Uh oh!

ibuclaw commented Jan 13, 2018

Uh oh!

ibuclaw Jan 13, 2018

Choose a reason for hiding this comment

Uh oh!

JinShil left a comment

Choose a reason for hiding this comment

Uh oh!

JinShil commented Jan 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants