Stub out the DUB download for GDC#7692
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jan 13, 2018
Merged
Conversation
The install script downloads `dub` by default if it isn't shipped by the binary release. That's the case for old DMD releases + GDC. `dub` is only used for the DMD as library tests and they don't work with `gdc` at the moment. In summary: we try to fetch `dub` from rather unstable `code.dlang.org` server and break the build due to download failures, but we don't even need `dub`.
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
This was referenced Jan 13, 2018
ibuclaw
approved these changes
Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install script downloads
dubby default if it isn't shipped by thebinary release. That's the case for old DMD releases + GDC.
So as mentioned in #7685, the gdc builds often fail with:
However,
dubis only used for the DMD as library tests and they don't work withgdcat the moment.In summary: we try to fetch
dubfrom rather unstablecode.dlang.orgserver and break the build due to download failures, but we don't even
need
dub.See also: #7691