Skip to content

Move glue layer to dmd.ir#7710

Closed
wilzbach wants to merge 2 commits intodlang:masterfrom
wilzbach:ir
Closed

Move glue layer to dmd.ir#7710
wilzbach wants to merge 2 commits intodlang:masterfrom
wilzbach:ir

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jan 14, 2018

Motivation

  • Makes it clear what the glue layer is and is to find where it's called
  • The DMD as a library shouldn't need to access dmd.ir - this makes it explicit
  • To keep things simple, this PR just moves the files - dmd.ir.glue_layer and dmd.ir.objc_glue are still required by the frontend

Script

replacements=(
"dmsc"
"e2ir"
"eh"
"glue"
"gluelayer"
"iasm"
"irstate"
"objc_glue"
"s2ir"
"tocsym"
"toctype"
"tocvdebug"
"todt"
"toir"
"toobj"
)
shopt -s globstar

for r in "${replacements[@]}" ; do
    w=($r)
    sed "s/dmd\.${w[0]}/dmd.ir.${w[0]}/g" -i **/*.d
done

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@rainers
Copy link
Member

rainers commented Jan 14, 2018

You seem to have missed dmd.irstate in your replacement list.

```bash
replacements=(
"dmsc"
"e2ir"
"eh"
"glue"
"gluelayer"
"iasm"
"irstate"
"objc_glue"
"s2ir"
"tocsym"
"toctype"
"tocvdebug"
"todt"
"toir"
"toobj"
)
shopt -s globstar

for r in "${replacements[@]}" ; do
    w=($r)
    sed "s/dmd\.${w[0]}/dmd.ir.${w[0]}/g" -i **/*.d
done
```
@WalterBright
Copy link
Member

No, I do not wish to split dmd up into lots of packages. I find it far more convenient to use a flat structure. The only reason root is separate is because it was originally intended to be a separate library. backend simply has to be separated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants