fix issue 18354 - [Reg 2.078] Building fails with VC 2015 Build Tools#7828
Merged
wilzbach merged 1 commit intodlang:stablefrom Feb 3, 2018
Merged
fix issue 18354 - [Reg 2.078] Building fails with VC 2015 Build Tools#7828wilzbach merged 1 commit intodlang:stablefrom
wilzbach merged 1 commit intodlang:stablefrom
Conversation
Contributor
JinShil
approved these changes
Feb 2, 2018
wilzbach
reviewed
Feb 2, 2018
src/dmd/link.d
Outdated
| OutBuffer cmdbuf; | ||
| if (auto p = getVCDir(VCDir.Lib, x64)) | ||
| if (auto vclibdir = getVCDir(VCDir.Lib, x64)) | ||
| if (vclibdir) |
Contributor
There was a problem hiding this comment.
Isn't this if unnecessary?
Member
Author
There was a problem hiding this comment.
Ooops, merge error. Removed and amended.
Contributor
|
Shouldn't this have been caught by AppVeyor? Any way we can ensure that it doesn't regress in the future? |
Contributor
AppVeyor doesn't appear to be running on stable. |
Contributor
Ah that's probably due to
|
…f legacy_stdio_definitions.lib
Member
Author
No, this only happens if no Visual Studio is installed, but the VC++ Build Tools. Last time I tried, the latter couldn't even be installed if there is already a VS installation on the system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace VS version check with check for existence of legacy_stdio_definitions.lib
cherry-picked from #7500