Fix no_Throwable test so it doesn't import druntime's object.d#7883
Merged
dlang-bot merged 1 commit intodlang:masterfrom Feb 13, 2018
JinShil:dflags_for_tests
Merged
Fix no_Throwable test so it doesn't import druntime's object.d#7883dlang-bot merged 1 commit intodlang:masterfrom JinShil:dflags_for_tests
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:dflags_for_tests
Conversation
Contributor
|
Thanks for your pull request, @JinShil! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
approved these changes
Feb 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #7845 is merged, we can properly create tests that don't automatically import druntime.
The
no_Throwabletest, added in #7786, also should clear DFLAGS to prevent druntime's object.d from being imported. This PR doesn't change the behavior of the test, as DMD, by chance, imported the correct object.d anyway, but this PR does make the desired behavior more explicit to avoid the potential for a false positive.