Add [Environment{arch}] DFLAGS to -v output#7937
Merged
dlang-bot merged 1 commit intodlang:masterfrom Mar 2, 2018
JinShil:dflags2
Merged
Add [Environment{arch}] DFLAGS to -v output#7937dlang-bot merged 1 commit intodlang:masterfrom JinShil:dflags2
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:dflags2
Conversation
JinShil
requested review from
MartinNowak,
WalterBright,
mathias-lang-sociomantic and
rainers
as code owners
Contributor
|
Thanks for your pull request, @JinShil! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
JinShil
commented
Feb 21, 2018
| environment.reset(7); // erase cached environment updates | ||
| arch = parse_arch_arg(&dflags, arch); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
dflags is never used after this point, and will actually contain incomplete information after the [Environment{arch}] section is parsed, so it is placed in it's own scope.
src/dmd/mars.d
Outdated
| environment.update("LIB", 3).ptrvalue = null; | ||
|
|
||
| // read from DFLAGS in [Environment{arch}] section | ||
| char[80] envsection; |
WalterBright
approved these changes
Feb 23, 2018
rainers
approved these changes
Feb 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #7865
#7865 printed DFLAGS from the
dflagslocal variable. Thedflagslocal variable was populated from the[Environment]section of the config file, but was never populated from the architecture-specific section of the config file (i.e.[Environment64])This PR defers reading DFLAGS from the
environmentstring table until needed in the-voutput, by which time the architecture-specific section of the config file has already been parsed.