fix Issue 17512 - [REG 2.073] [DIP1000] Error on bad interplay of 'au…

[WalterBright]

…to ref' and 'return' attribute deduction

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	17512	regression	[REG 2.073] [DIP1000] Error on bad interplay of 'auto ref' and 'return' attribute deduction.

[wilzbach]

(rebased to stable)

[wilzbach]

LGTM though it feels like this is a bit of a workaround against the fact that return is added somewhere in DMD before.

[wilzbach]

DAutoTest failure is unrelated and would need dlang/dlang.org#2270

[WalterBright]

oh gawd, not again

[WalterBright]

Abandoning this mess.

[wilzbach]

oh gawd, not again

Did you force-push?

[WalterBright]

I redid it as #8006

[wilzbach]

Abandoning this mess.

Just fixed it for you. Just do a git pull if other people made changes to your PR.
In this case it was just git rebase --onto upstream/stable upstream/master

[WalterBright]

Thanks! In that case, I'll turn on automerge before any more changes bork it again.

[wilzbach]

before any more changes bork it again.

For the future, if someone else force-pushed onto your branch, you need to reset your local branch to it before adding changes as otherwise the previous work will be overwritten.
In short: there's e.g. git pull -f to reset you branch to the remote state.

[WalterBright]

The failing win64 test looks spurious, I deprecated the test, but it won't rerun it.

[rainers]

The failing win64 test looks spurious, I deprecated the test, but it won't rerun it.

Looks like @braddr is in the middle of updating the build servers. It is trying to compile with VC2010.

[wilzbach]

I deprecated the test, but it won't rerun it.

I tried to deprecate it too for a few times and auto-tester seems to remove the deleted status ...

Looks like @braddr is in the middle of updating the build servers. It is trying to compile with VC2010.

The machine is broken since almost two weeks: braddr/d-tester#71