Skip to content

Comments

Fix issue 18504 - Generate unwind tables for halting functions#8027

Merged
dlang-bot merged 1 commit intodlang:masterfrom
LemonBoy:b18504
Apr 2, 2018
Merged

Fix issue 18504 - Generate unwind tables for halting functions#8027
dlang-bot merged 1 commit intodlang:masterfrom
LemonBoy:b18504

Conversation

@LemonBoy
Copy link
Contributor

I think #7333 heuristic is too eager.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @LemonBoy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18504 major Assert in synchronized crashes with SIGILL on exit

@JinShil
Copy link
Contributor

JinShil commented Mar 18, 2018

LGTM, but I'm not really qualified. @WalterBright or @ibuclaw, please review.

@WalterBright
Copy link
Member

When creating a PR to fix a bugzilla issue, please post a link to the PR in the issue. This is so that someone browsing bug reports will know if and where a PR for it is.

@ibuclaw
Copy link
Member

ibuclaw commented Mar 20, 2018

Why is this information in the frontend? This is a backend check, and dmd specific.

@WalterBright
Copy link
Member

All it does is set a flag, which is then used by the glue code and back end.

@dlang-bot dlang-bot merged commit 0038ec3 into dlang:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants