account for 'unsigned long' name mangling in OSX 32#8243
account for 'unsigned long' name mangling in OSX 32#8243WalterBright merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8243" |
|
ping @braddr |
|
If this is required for the auto-tester to upgrade to a newer DMD version, targeting stable might help (and tests of course, too). |
|
This is needed to compile dmd with 2.079 on OSX. No new tests are needed, because it failed the autotester build the way it is now. |
|
Blocking #8112 |
|
I'd be happy to review this, but I need some context. What's the problem and how does this fix it? |
|
The problem comes when using dmd 2.079 as the boot compiler on OSX: https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3161515&isPull=true I have fixes for the unsigned long mangling issue itself, but those aren't in the 2.079 yet. Hence this PR which is a workaround. |
should we target a later base compiler then? |
It's so hard getting this moving forward with all the hand-wringing, I mean months and months and months of delays, I do not wish to start over with a new version. Let's just get this done. |
|
FWIW if this is already fixed in 2.080, then there's nothing stopping Brad from using that one... Of course I don't object to this PR. |
|
I'll take that as approval :-) |
No description provided.