Fix typo in dmd.expression apparently causing sporadic frontend crashes#8294
Fix typo in dmd.expression apparently causing sporadic frontend crashes#8294dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8294" |
|
That was quick, thanks; I should have targeted stable though. :/ Pinging @MartinNowak. |
|
Ah we typically only do cherry-picking if it's important, so if you feel like this really should be part of 2.080.1, simply cherry-pick and open a new PR. |
|
@wilzbach: So a fix for random DMD segfaults isn't important enough to be cherry-picked by one of you guys? What is then? ;) |
|
Sorry about that – I was on my phone, and the mobile version doesn't display the target branch, so I didn't notice. |
|
Ehm I'm currently traveling and without laptop, otherwise I would have opened the cherry-pick for you. |
|
This PR was a bug fix for https://issues.dlang.org/show_bug.cgi?id=18864 |
Seems to fix sporadic segfaults reported in https://issues.dlang.org/show_bug.cgi?id=18864.