Allow classes and interfaces with only static members to be used in -betterC#8324
Closed
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:betterc_classes
Closed
Allow classes and interfaces with only static members to be used in -betterC#8324JinShil wants to merge 1 commit intodlang:masterfrom JinShil:betterc_classes
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:betterc_classes
Conversation
Contributor
|
Thanks for your pull request, @JinShil! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8324" |
JinShil
added
Review:WIP
JinShil
requested review from
Geod24,
MartinNowak,
WalterBright and
rainers
as code owners
JinShil
commented
Jun 3, 2018
| m.dsymbolSemantic(null); | ||
| } | ||
|
|
||
| backend_init(); |
Contributor
Author
There was a problem hiding this comment.
The backend is dependent on whether Throwable is declared, so we have to move its initialization until after dsymbolSemantic.
Contributor
Author
|
Gah! This is not going to work if we want to allow using I think if we had a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #8204, but for -betterC.
dlang/druntime#2194 was merged, which prevents -betterC from importing symbols that -betterC cannot utilize. This means the logic added for #8204 can now be utilized for -betterC builds as well.
However, with -betterC builds, object.d is still imported and parsed in its entirety;
TypeInfo,ModuleInfo, and other unsupported features are just versioned out. Therefore, I had to move the logic for setting the specialClassDeclarations, out of the parsing phase and into the symbol semantic phase.