Skip to content

Fix issue 14178 - extern(C++) doesn't mangle 'std' correctly on posix systems#8341

Merged
dlang-bot merged 1 commit intodlang:masterfrom
TurkeyMan:mangle_std
Jun 8, 2018
Merged

Fix issue 14178 - extern(C++) doesn't mangle 'std' correctly on posix systems#8341
dlang-bot merged 1 commit intodlang:masterfrom
TurkeyMan:mangle_std

Conversation

@TurkeyMan
Copy link
Contributor

No description provided.

@TurkeyMan TurkeyMan requested a review from ibuclaw as a code owner June 8, 2018 05:29
@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 8, 2018

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18957 normal extern(C++) doesn't mangle 'std' correctly on posix systems

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8341"

@Geod24 Geod24 changed the title Fix issue 18957 - extern(C++) doesn't mangle 'std' correctly on posix systems Fix issue 14178 - extern(C++) doesn't mangle 'std' correctly on posix systems Jun 8, 2018
Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Updated the title to reference https://issues.dlang.org/show_bug.cgi?id=14178

@Geod24 Geod24 added Merge:auto-merge Review:Vision Vision Plan https://wiki.dlang.org/Vision/2018H1 and removed Severity:Enhancement labels Jun 8, 2018
@dlang-bot dlang-bot merged commit cce909b into dlang:master Jun 8, 2018
@TurkeyMan TurkeyMan deleted the mangle_std branch June 9, 2018 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Vision Vision Plan https://wiki.dlang.org/Vision/2018H1 Severity:Bug Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants