Skip to content

Comments

convert gflow.c to D#8424

Merged
wilzbach merged 1 commit intodlang:masterfrom
WalterBright:gflow.d
Jul 1, 2018
Merged

convert gflow.c to D#8424
wilzbach merged 1 commit intodlang:masterfrom
WalterBright:gflow.d

Conversation

@WalterBright
Copy link
Member

@WalterBright WalterBright commented Jul 1, 2018

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 1, 2018

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8424"

@WalterBright WalterBright force-pushed the gflow.d branch 4 times, most recently from 5dd7b68 to ca0bc1d Compare July 1, 2018 01:41
@WalterBright
Copy link
Member Author

WalterBright commented Jul 1, 2018

@CyberShadow looks like a problem with CyberShadow/DAutoTest :

Test the D Language specification
../dmd/generated/linux/release/64/dmd -run tools/dspec_tester.d --compiler=../dmd/generated/linux/release/64/dmd
/usr/bin/ld: final link failed: No space left on device
collect2: error: ld returned 1 exit status
Error: linker exited with status 1
posix.mak:811: recipe for target 'test_dspec' failed

wilzbach
wilzbach approved these changes Jul 1, 2018
View reviewed changes
src/dmd/backend/gloop.c

extern "C"
{
void fillInDNunambig(vec_t v, elem *e)
Copy link
Contributor

@wilzbach wilzbach Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this change unrelated?

Copy link
Member Author

@WalterBright WalterBright Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I set it to C to avoid name mangling issues with vec_t which is our annoying friend size_t.

src/dmd/backend/gflow.d

void vec_setclear(size_t b, vec_t vs, vec_t vc) { vec_setbit(b, vs); vec_clearbit(b, vc); }

bool Eunambig(elem* e) { return OTassign(e.Eoper) && e.EV.E1.Eoper == OPvar; }
Copy link
Contributor

@wilzbach wilzbach Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already defined in gdag.d - why not import it (or move it to a common bit)?

Copy link
Member Author

@WalterBright WalterBright Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the 'header' files are a mess at the moment, and I decided to defer dealing with that. My goal is to do the least disruptive thing to get the files converted to D. Then, start doing refactoring and removing technical debt.

@wilzbach wilzbach merged commit 67963b9 into dlang:master Jul 1, 2018
wilzbach added a commit to wilzbach/dmd that referenced this pull request Jul 1, 2018
@wilzbach
Merge pull request dlang#8424 from WalterBright/gflow.d
a6e5f5b 
convert gflow.c to D
@WalterBright WalterBright deleted the gflow.d branch July 1, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinNowak MartinNowak Awaiting requested review from MartinNowak MartinNowak is a code owner

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

@dnadlinger dnadlinger Awaiting requested review from dnadlinger

1 more reviewer

@wilzbach wilzbach wilzbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WalterBright @dlang-bot @wilzbach