Filename: Convert extension-related code to use D slices#8672
Filename: Convert extension-related code to use D slices#8672Geod24 wants to merge 8 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @Geod24! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8672" |
src/dmd/root/filename.d
Outdated
| { | ||
| stat_t st; | ||
| if (stat(name, &st) < 0) | ||
| if (name.toCStringThen!((v) => stat(v.ptr, &st)) < 0) |
There was a problem hiding this comment.
The parentheses around v in the lambda parameter list is not necessary.
src/dmd/root/filename.d
Outdated
| /// Ditto | ||
| extern (D) static bool equalsExt(const(char)[] name, const(char)[] ext) pure | ||
| { | ||
| auto e = FileName.ext(name); |
|
LGTM. |
|
Addressed @jacob-carlborg 's comments |
|
This isn't needed anymore, the main PR was merged. |
3 participants
Better reviewed commit-by commit.
Spin off #8575