Skip to content

Add aliases to ASTCodegen for dmd#8591#8776

Merged
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:patch-4
Oct 1, 2018
Merged

Add aliases to ASTCodegen for dmd#8591#8776
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:patch-4

Conversation

@thewilsonator
Copy link
Contributor

@thewilsonator thewilsonator commented Sep 30, 2018

So that #8591's dtoh can be built against an unmodified dmd (e.g as a dub package).

cc @ibuclaw

So that dmd#8591's dtoh can be built against an unmodified dmd (e.g as a dub package).
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8776"

@dlang-bot dlang-bot merged commit 8164eb3 into dlang:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants