Skip to content

Expose DMD's command line parsing#8878

Merged
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:patch-6
Oct 29, 2018
Merged

Expose DMD's command line parsing#8878
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:patch-6

Conversation

@thewilsonator
Copy link
Contributor

For DMDFE as a library so that tools can populate global.params correctly.

Required for https://github.com/thewilsonator/dtoh the dub package of #8591

For DMDFE as a library so that tools can populate `global.params` correctly.

Required for https://github.com/thewilsonator/dtoh the dub package of dlang#8591
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8878"

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note: we should really move those things to a driver package

@Geod24 Geod24 added Review:Trivial typos, formatting, comments Merge:auto-merge labels Oct 28, 2018
@thewilsonator
Copy link
Contributor Author

That would be nice. Also atuomerge won't merge because of unrelated CyberShadow/DAutoTest failure.

@Geod24
Copy link
Member

Geod24 commented Oct 28, 2018

It will retry automatically at some point. You can also rebase and repush if you want to speed things up. Since it's Required, I cannot merge directly.

@thewilsonator
Copy link
Contributor Author

rebase and repush

That will remove the auto merge label though, IIRC.

Since it's Required, I cannot merge directly.

So it will have to wait until dpl-docs is fixed? Oh well.

@Geod24
Copy link
Member

Geod24 commented Oct 28, 2018

Oh I didn't realize it was triggering on all PRs... Looks related to the new dub release ?

@thewilsonator
Copy link
Contributor Author

Maybe? I've no idea.

@thewilsonator
Copy link
Contributor Author

There's a thread on Slack's #ci

@thewilsonator
Copy link
Contributor Author

Retriggering CI now that dlang/dlang.org#2497 is in

@Geod24
Copy link
Member

Geod24 commented Oct 29, 2018

Didn't seem to have worked :/

@thewilsonator
Copy link
Contributor Author

Indeed, it didn't restart though, that log is dated yesterday.

@thewilsonator
Copy link
Contributor Author

Do I need to close it for more than 4 seconds? :)

@Geod24
Copy link
Member

Geod24 commented Oct 29, 2018

I think closing doesn't help, but rebasing will.

@thewilsonator
Copy link
Contributor Author

Here goes...

@wilzbach
Copy link
Contributor

Yup for the record the only way to restart DAutotest is by rebasing. However, it will automatically rebuild PRs if master had moved ahead (master here refers to all projects) and its idling, so all PRs should turn green in a few hours automatically.

@dlang-bot dlang-bot merged commit 1fa0ea2 into dlang:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants