Expose DMD's command line parsing#8878
Conversation
For DMDFE as a library so that tools can populate `global.params` correctly. Required for https://github.com/thewilsonator/dtoh the dub package of dlang#8591
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8878" |
Geod24
left a comment
There was a problem hiding this comment.
On a side note: we should really move those things to a driver package
|
That would be nice. Also atuomerge won't merge because of unrelated CyberShadow/DAutoTest failure. |
|
It will retry automatically at some point. You can also rebase and repush if you want to speed things up. Since it's |
That will remove the auto merge label though, IIRC.
So it will have to wait until |
|
Oh I didn't realize it was triggering on all PRs... Looks related to the new dub release ? |
|
Maybe? I've no idea. |
|
There's a thread on Slack's #ci |
|
Retriggering CI now that dlang/dlang.org#2497 is in |
|
Didn't seem to have worked :/ |
|
Indeed, it didn't restart though, that log is dated yesterday. |
|
Do I need to close it for more than 4 seconds? :) |
|
I think closing doesn't help, but rebasing will. |
|
Here goes... |
|
Yup for the record the only way to restart DAutotest is by rebasing. However, it will automatically rebuild PRs if master had moved ahead (master here refers to all projects) and its idling, so all PRs should turn green in a few hours automatically. |
For DMDFE as a library so that tools can populate
global.paramscorrectly.Required for https://github.com/thewilsonator/dtoh the dub package of #8591