Skip to content

Comments

Fix Issue 19471 - Duplicate error messages when trying to use an inaccessible package symbol#9056

Closed
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:fix_19471
Closed

Fix Issue 19471 - Duplicate error messages when trying to use an inaccessible package symbol#9056
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:fix_19471

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Dec 10, 2018

This is actually a followup to #8443. It removes what appears to be a redundant deprecation message in

fail_compilation/fail313.d(24): Deprecation: `imports.a313.core` is not visible from module `test313`

It also happens to solve Issue 19014. I didn't add a test specific to Issue 19014 because the changes to fail313.d seem to cover it.

cc @RazvanN7

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19471 normal Duplicate error messages when trying to use an inaccessible package symbol

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9056"

@JinShil
Copy link
Contributor Author

JinShil commented Dec 10, 2018

Grrr. This doesn't look like the right fix. The way forward is probably to adopt #7241 first.

@JinShil JinShil closed this Dec 10, 2018
@JinShil JinShil deleted the fix_19471 branch December 10, 2018 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants