Fix Issue 19471 - Duplicate error messages when trying to use an inaccessible package symbol#9056
Closed
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:fix_19471
Closed
Fix Issue 19471 - Duplicate error messages when trying to use an inaccessible package symbol#9056JinShil wants to merge 1 commit intodlang:masterfrom JinShil:fix_19471
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:fix_19471
Conversation
…cessible package symbol
Contributor
|
Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9056" |
thewilsonator
approved these changes
Dec 10, 2018
Contributor
Author
|
Grrr. This doesn't look like the right fix. The way forward is probably to adopt #7241 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually a followup to #8443. It removes what appears to be a redundant deprecation message in
dmd/test/fail_compilation/fail313.d
Line 5 in 987012b
It also happens to solve Issue 19014. I didn't add a test specific to Issue 19014 because the changes to fail313.d seem to cover it.
cc @RazvanN7