Skip to content

fix reg in master - __traits alone gives a SEGFAULT#9084

Merged
WalterBright merged 1 commit intomasterfrom
unknown repository
Dec 16, 2018
Merged

fix reg in master - __traits alone gives a SEGFAULT#9084
WalterBright merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 15, 2018

This is a regression in master so i don't open an issue to prevent it to appear in the changelog.

The regression was introduced by #8938. When the source is just __trait, an incomplete but valid TypeTrait is parsed. Later hdrgen tried to format the trait the fault happened because of a null identifier.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9084"

@ghost ghost requested a review from WalterBright as a code owner December 15, 2018 17:02
@WalterBright WalterBright merged commit 5ceddec into dlang:master Dec 16, 2018
@ghost ghost deleted the traits-alone-segfault branch December 16, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants