fix issue 19510 - random and spurious error about a missing NOLOGO.d file

[ghost]

There was a missing strlen on a static array that caused random things. One of them is that replaceName failed and the linker name was set to dmd filename, causing dmd to be called with the linker arguments.

[dlang-bot]

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19510	regression	[2.084 REG] random and spurious error about a missing NOLOGO.d file

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9142"

[thewilsonator]

Can you do a test for this?

[ghost]

I'll try to fix the issue in a first place.

[ghost]

I don't know how to test this (because of the random nature of the bug) but I'm super confident about what was the problem and that the fix is good.

[jacob-carlborg]

Please squash the commits.

[ghost]

ready for merge.

[andre2007]

Thank you for solving this nasty bug

[ghost]

your're welcome @andre2007, it was a typical "C" bug.