Skip to content

Comments

Fix typo in test16096.sh: ${EXT} -> ${EXE}#9213

Merged
wilzbach merged 1 commit intodlang:stablefrom
ThomasMader:stable
Jan 7, 2019
Merged

Fix typo in test16096.sh: ${EXT} -> ${EXE}#9213
wilzbach merged 1 commit intodlang:stablefrom
ThomasMader:stable

Conversation

@ThomasMader
Copy link
Contributor

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ThomasMader! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9213"

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I wonder why it passed on the testsuite as the script that sources this does among other a set -u

@wilzbach wilzbach merged commit 06b3141 into dlang:stable Jan 7, 2019
@ThomasMader
Copy link
Contributor Author

Hmm I wonder why it passed on the testsuite as the script that sources this does among other a set -u

Strange indeed. I got a EXT: unbound variable on MacOS with Nix but on NixOS (Linux) it was not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants